[Validator] Allow Validator without the translator component #28520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99671a1 to
9e5ea39
Compare
xabbuh
reviewed
Sep 19, 2018
|
|
||
| foreach ($builder->getMethodCalls() as list($method, $arguments)) { | ||
| if ('setTranslator' === $method) { | ||
| $translator = $arguments[0] instanceof Reference ? $container->findDefinition($arguments[0]) : $arguments[0]; | ||
| if ($arguments[0] instanceof Reference) { |
There was a problem hiding this comment.
Wouldn't it be enough to make sure that the reference is tagged with IGNORE_ON_INVALID_REFERENCE (see https://symfony.com/doc/4.0/service_container/optional_dependencies.html#ignoring-missing-dependencies)?
There was a problem hiding this comment.
Just setting the reference as "nullable" wouldn't work, we'd have the same error. Though, your put is interesting: I've made sure it ignores the reference only if it's "nullable".
There was a problem hiding this comment.
Actually no. I've just reverted 3e545e4 as it would break the ValidatorBuilderInterface. AFAIK, that's the only way of dealing with it here.
3e545e4 to
9e5ea39
Compare
9e5ea39 to
c0d7091
Compare
nicolas-grekas
approved these changes
Sep 20, 2018
c0d7091 to
5c56d01
Compare
5c56d01 to
2dc92d7
Compare
|
FYI, it's a very important bug, it prevents the following to work: |
chalasr
approved these changes
Sep 20, 2018
|
Thank you @sroze. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 20, 2018
…nt (sroze) This PR was merged into the 4.2-dev branch. Discussion ---------- [Validator] Allow Validator without the translator component | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28210 | License | MIT | Doc PR | ø Validator should be available without the Translator service. #28210 introduced a regression, it was not the case anymore: ``` You have requested a non-existent service "translator". ``` This fixes it. Commits ------- 2dc92d7 Allow validator without the translator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validator should be available without the Translator service. #28210 introduced a regression, it was not the case anymore:
This fixes it.