From 85b832bcc9d862d6e372acd19f5d5ef23e46d7fb Mon Sep 17 00:00:00 2001 From: Roland Franssen Date: Sat, 9 Jun 2018 09:49:02 +0200 Subject: [PATCH] [HttpKernel] Log/Collect exceptions at prio 0 --- src/Symfony/Component/HttpKernel/CHANGELOG.md | 2 +- .../Component/HttpKernel/EventListener/ExceptionListener.php | 3 +-- .../Component/HttpKernel/EventListener/ProfilerListener.php | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/Symfony/Component/HttpKernel/CHANGELOG.md b/src/Symfony/Component/HttpKernel/CHANGELOG.md index f64905cbe086e..c98d2235e333d 100644 --- a/src/Symfony/Component/HttpKernel/CHANGELOG.md +++ b/src/Symfony/Component/HttpKernel/CHANGELOG.md @@ -5,7 +5,7 @@ CHANGELOG ----- * added orphaned events support to `EventDataCollector` - * `ExceptionListener` now logs and collects exceptions at priority `2048` (previously logged at `-128` and collected at `0`) + * `ExceptionListener` now logs exceptions at priority `0` (previously logged at `-128`) * Deprecated `service:action` syntax with a single colon to reference controllers. Use `service::method` instead. * Added the ability to profile individual argument value resolvers via the `Symfony\Component\HttpKernel\Controller\ArgumentResolver\TraceableValueResolver` diff --git a/src/Symfony/Component/HttpKernel/EventListener/ExceptionListener.php b/src/Symfony/Component/HttpKernel/EventListener/ExceptionListener.php index fc749de599a48..4812f426951c8 100644 --- a/src/Symfony/Component/HttpKernel/EventListener/ExceptionListener.php +++ b/src/Symfony/Component/HttpKernel/EventListener/ExceptionListener.php @@ -44,7 +44,6 @@ public function __construct($controller, LoggerInterface $logger = null, $debug public function logKernelException(GetResponseForExceptionEvent $event) { $exception = $event->getException(); - $request = $event->getRequest(); $this->logException($exception, sprintf('Uncaught PHP Exception %s: "%s" at %s line %s', get_class($exception), $exception->getMessage(), $exception->getFile(), $exception->getLine())); } @@ -90,7 +89,7 @@ public static function getSubscribedEvents() { return array( KernelEvents::EXCEPTION => array( - array('logKernelException', 2048), + array('logKernelException', 0), array('onKernelException', -128), ), ); diff --git a/src/Symfony/Component/HttpKernel/EventListener/ProfilerListener.php b/src/Symfony/Component/HttpKernel/EventListener/ProfilerListener.php index 9cc554db72ab0..045e08347ff81 100644 --- a/src/Symfony/Component/HttpKernel/EventListener/ProfilerListener.php +++ b/src/Symfony/Component/HttpKernel/EventListener/ProfilerListener.php @@ -121,7 +121,7 @@ public static function getSubscribedEvents() { return array( KernelEvents::RESPONSE => array('onKernelResponse', -100), - KernelEvents::EXCEPTION => array('onKernelException', 2048), + KernelEvents::EXCEPTION => array('onKernelException', 0), KernelEvents::TERMINATE => array('onKernelTerminate', -1024), ); }