[Routing] Fix throwing NoConfigurationException instead of 405 #26792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #26759 |
| License | MIT |
| Doc PR | - |
742e091 to
73269cf
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Apr 4, 2018
… 405 (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [Routing] Fix throwing NoConfigurationException instead of 405 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26759 | License | MIT | Doc PR | - Commits ------- 73269cf [Routing] Fix throwing NoConfigurationException instead of 405
|
@nicolas-grekas There is a possible BC break introduced by this change (InterNations/http-mock#45) now for the path '/' and others if the allowed methods are not configured it throws different exceptions, can you please confirm this is the expected behaviour for the clients of the symfony router. |
|
I don't know how your test behaved before the change, and how it fails now, so I can't answer for now. |
|
@nicolas-grekas Thanks for the reply, will do that 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.