[SecurityBundle] Add missing argument to security.authentication.provider.simple #26762
Conversation
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #26753 |
| License | MIT |
| Doc PR | - |
58c08c6 to
e8433cb
Compare
| @@ -210,6 +210,7 @@ | |||
| <argument /> <!-- Simple Authenticator --> | |||
| <argument /> <!-- User Provider --> | |||
| <argument /> <!-- Provider-shared Key --> | |||
| <argument>null</argument><!-- User Checker --> | |||
There was a problem hiding this comment.
Explicit null because while SimpleFormFactory::createAuthProvider() does replace the argument, SimplePreAuthenticationFactory::create() doesn't, thus keeps it as is.
There was a problem hiding this comment.
@nicolas-grekas success tested on 4.0.7
There was a problem hiding this comment.
yes its works for me Thnaks @nicolas-grekas
|
@nicolas-grekas Yes i will take a look |
|
@nicolas-grekas I would also replace the argument in the |
|
@i3or1s would you mind opening a PR doing so? (you can borrow the patch here also so I'll close this one.) |
|
@nicolas-grekas No problems I will do so now. |
|
Closing in favor of #26774, thanks @nicolas-grekas. |
…cation.provider.simple (i3or1s, chalasr) This PR was merged into the 2.8 branch. Discussion ---------- [SecurityBundle] Add missing argument to security.authentication.provider.simple | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26753 | License | MIT | Doc PR | - Created PR in relation to a conversation in [PR](#26762) #26762 Commits ------- c82c2f1 [SecurityBundle] Add test for simple authentication config 1b26aac [SecurityBundle] Add missing argument to security.authentication.provider.simple