8000 [TwigBridge] allow html5 compatible rendering of forms with null names by ninze · Pull Request #26584 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[TwigBridge] allow html5 compatible rendering of forms with null names #26584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[TwigBridge] allow html5 compatible rendering of forms with null names #26584

wants to merge 1 commit into from

Conversation

ninze
Copy link
Contributor
@ninze ninze commented Mar 18, 2018

Fixes html5 validation error with null form names.

@nicolas-grekas nicolas-grekas changed the title allow html5 compatible rendering of forms with null names [TwigBridge] allow html5 compatible rendering of forms with null names Mar 19, 2018
nicolas-grekas
nicolas-grekas approved these changes Mar 19, 2018
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for 3.4)

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Mar 19, 2018
javiereguiluz
javiereguiluz approved these changes Mar 20, 2018
View reviewed changes
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference:

name
The name of the form. In HTML 4, its use is deprecated (id should be used instead). It must be unique among the forms in a document and not just an empty string in HTML 5.

Source: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/form

@fabpot
Copy link
Member
fabpot commented Mar 20, 2018

Thank you @systemist.

@fabpot fabpot closed this Mar 20, 2018
fabpot added a commit that referenced this pull request Mar 20, 2018
@fabpot
bug #26584 [TwigBridge] allow html5 compatible rendering of forms wit…
a1be12e 
…h null names (systemist)

This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #26584).

Discussion
----------

[TwigBridge] allow html5 compatible rendering of forms with null names

Fixes html5 validation error with null form names.

Commits
-------

01c9e3c allow html5 compatible rendering of forms with null names
This was referenced Apr 2, 2018
Merged
Merged
Merged
Merged
@xabbuh xabbuh modified the milestones: 3.4, 2.7 Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug Form Status: Reviewed TwigBridge
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
6 participants
@ninze @fabpot @javiereguiluz @nicolas-grekas @xabbuh @carsonbot
0