[Config] ReflectionClassResource check abstract class #26400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@jakzal yes, add issue |
chalasr
reviewed
Mar 12, 2018
| } | ||
|
|
||
| if ($class->isSubclassOf(ServiceSubscriberInterface::class)) { | ||
| yield ServiceSubscriberInterface::class; | ||
| yield print_r(\call_user_func(array($class->name, 'getSubscribedServices')), true); | ||
| if (!$class->isAbstract()) { |
There was a problem hiding this comment.
should also check for isInterface()
| @@ -157,12 +157,16 @@ private function generateSignature(\ReflectionClass $class) | |||
|
|
|||
| if ($class->isSubclassOf(EventSubscriberInterface::class)) { | |||
| yield EventSubscriberInterface::class; | |||
| yield print_r(\call_user_func(array($class->name, 'getSubscribedEvents')), true); | |||
| if (!$class->isAbstract()) { | |||
There was a problem hiding this comment.
the check should be merged in the above "if", no need to yield EventSubscriberInterface::class
(same below, and I agree with @chalasr comment below also)
There was a problem hiding this comment.
or, just before the current two checks, we could just add
if ($class->isAbstract() || $class->isInterface()) {
return;
}
…rface and EventSubscriberInterface
nicolas-grekas
approved these changes
Mar 12, 2018
chalasr
approved these changes
Mar 13, 2018
fabpot
approved these changes
Mar 13, 2018
|
Thank you @andrey1s. |
fabpot
added a commit
that referenced
this pull request
Mar 13, 2018
…rey1s) This PR was merged into the 3.4 branch. Discussion ---------- [Config] ReflectionClassResource check abstract class generate Signature update hash methods `ServiceSubscriberInterface::getSubscribedServices` and `EventSubscriberInterface::getSubscribedEvents` if the class is not abstract | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26459, #26501 | License | MIT Commits ------- e851514 [Config] ReflectionClassResource check abstract ServiceSubscriberInterface and EventSubscriberInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate Signature
update hash methods
ServiceSubscriberInterface::getSubscribedServicesandEventSubscriberInterface::getSubscribedEventsif the class is not abstract