8000 Fix undiscoverablility of SymfonyTestsListenerForV7 by keradus · Pull Request #26184 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Fix undiscoverablility of SymfonyTestsListenerForV7 #26184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2018

Conversation

keradus
Copy link
Member
@keradus keradus commented Feb 15, 2018
Q A
Branch? 3.4@dev (and 4@dev)
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? n/a
Fixed tickets n/a
License MIT
Doc PR n/a

As class is in wrong namespace, it's not discoverable by autoloader and during execution of aliasing we face following crash:

ker@dus:~/github/PHP-CS-Fixer λ vendor/bin/phpunit 
Class 'Symfony\Bridge\PhpUnit\Legacy\SymfonyTestsListenerForV7' not found

replaces #26180, which was wrongly sent (and merged) for master branch instead of 3.4, sorry for mistake.

@nicolas-grekas
Copy link
Member

Thank you @keradus.

@nicolas-grekas nicolas-grekas merged commit 538b257 into symfony:3.4 Feb 15, 2018
nicolas-grekas added a commit that referenced this pull request Feb 15, 2018
…adus)

This PR was merged into the 3.4 branch.

Discussion
----------

Fix undiscoverablility of SymfonyTestsListenerForV7

| Q             | A
| ------------- | ---
| Branch?       | `3.4@dev` (and `4@dev`)
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | n/a
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

As class is in wrong namespace, it's not discoverable by autoloader and during execution of aliasing we face following crash:
```
ker@dus:~/github/PHP-CS-Fixer λ vendor/bin/phpunit
Class 'Symfony\Bridge\PhpUnit\Legacy\SymfonyTestsListenerForV7' not found
```

-----------------

replaces #26180, which was wrongly sent (and merged) for `master` branch instead of `3.4`, sorry for mistake.

Commits
-------

538b257 Fix undiscoverablility of SymfonyTestsListenerForV7
@keradus keradus deleted the 3.4_phpunit_fix branch February 15, 2018 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0