[DX] [DI] Improve exception for invalid setter injection arguments #25663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Come to think of it now - we could just also force-wrap the second argument into an array so the currently failing syntax also works. Don't see a reason why not. |
|
@nicolas-grekas before I rebase - what's your take on just force-wrapping the array. I think it's harmless convenience and it makes the exception obsolete. |
|
Alternative ways to write configuration create dead end for user experience (people need to learn two ways of doing things, so they can just read config from different people) |
ee2fea3 to
6850a22
Compare
|
Rebased. |
fabpot
approved these changes
Jan 3, 2018
|
Thank you @curry684. |
fabpot
added a commit
that referenced
this pull request
Jan 3, 2018
… arguments (curry684) This PR was merged into the 3.4 branch. Discussion ---------- [DX] [DI] Improve exception for invalid setter injection arguments | Q | A | ------------- | --- | Branch? | 4.0 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | License | MIT Improve the exception message for when you accidentally write setter injection wrong as I did too many times: ```yaml My\Logging\Service: calls: [ [ setLogger, "@logger" ] ] ``` Used to throw: > Type error: Argument 2 passed to Symfony\Component\DependencyInjection\Definition::addMethodCall() must be of the type array, object given, called in /var/www/project/vendor/symfony/dependency-injection/Loader/YamlFileLoader.php on line 457 Now throws: > The second parameter for function call "setLogger" must be an array of its arguments for service "My\Namespace\Service" in /var/www/project/config/services.yaml. Check your YAML syntax in /var/www/project/config/services.yaml (which is loaded in resource "/var/www/project/config/services.yaml"). (semi-offtopic: why isn't `LoggerAwareInterface` in the default autoconfigure for FrameworkExtension?) Commits ------- 6850a22 [DX] [DI] Improve exception for invalid setter injection arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the exception message for when you accidentally write setter injection wrong as I did too many times:
Used to throw:
Now throws:
(semi-offtopic: why isn't
LoggerAwareInterfacein the default autoconfigure for FrameworkExtension?)