Problem in phar #25579
Closed
Problem in phar #25579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If packed into phar the old version creates path like 'file:///phar%3A/'.
like last commit: If packed into phar the old version creates path like 'file:///phar%3A/'.
|
hello, thanks for this PR |
|
by correcting to fit the tests, i found its only a problem, if the whole project is insite a phar archive and the tempfiles cannot be written (in my case). Probably there is an other case, where temp cannot be written and the file then must be read from insite the phar. |
|
actually I'm not sure I understand the old code :) |
|
it should work without any problem. |
|
but if it can always work without, why use them in the first place? |
|
there are teo options:
so i would prefere first to check if it is possible zo get the file out of the phar as tempfile, this brings fever ram and better performance. |
nicolas-grekas
approved these changes
Jan 16, 2018
|
It looks like this bug exists in 2.7 as well. @betzholz Can you switch to 2.7 instead? Thanks. |
betzholz
pushed a commit
to betzholz/symfony
that referenced
this pull request
Jan 17, 2018
|
see #25816 |
fabpot
pushed a commit
that referenced
this pull request
Jan 17, 2018
fabpot
added a commit
that referenced
this pull request
Jan 17, 2018
This PR was squashed before being merged into the 2.7 branch (closes #25816). Discussion ---------- Problem in phar see mergerequest #25579 | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> If packed into phar the old version creates path like 'file:///phar%3A/'. see #25579 Commits ------- 3e0c8ff Problem in phar see mergerequest #25579
symfony-splitter
pushed a commit
to symfony/dependency-injection
that referenced
this pull request
Jan 17, 2018
This PR was squashed before being merged into the 2.7 branch (closes #25816). Discussion ---------- Problem in phar see mergerequest #25579 | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> If packed into phar the old version creates path like 'file:///phar%3A/'. see symfony/symfony#25579 Commits ------- 3e0c8ffb43 Problem in phar see mergerequest #25579
symfony-splitter
pushed a commit
to symfony/translation
that referenced
this pull request
Jan 17, 2018
This PR was squashed before being merged into the 2.7 branch (closes #25816). Discussion ---------- Problem in phar see mergerequest #25579 | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> If packed into phar the old version creates path like 'file:///phar%3A/'. see symfony/symfony#25579 Commits ------- 3e0c8ffb43 Problem in phar see mergerequest #25579
xabbuh
added a commit
that referenced
this pull request
Jan 18, 2018
* 2.7: fix the Composer API being used [Debug] Always decorate existing exception handlers to deal with fatal errors Enableable ArrayNodeDefinition is disabled for empty configuration Fixing a bug where the dump() function depended on bundle ordering Add nn (Norwegian Nynorsk) translation files, and improve existing file Problem in phar see mergerequest #25579 [Form] Disallow transform dates beyond the year 9999 Copied NO language files to the new NB locale. [Console] Improve phpdoc on StyleInterface::ask()
xabbuh
added a commit
that referenced
this pull request
Jan 18, 2018
* 2.8: fix the Composer API being used [Debug] Always decorate existing exception handlers to deal with fatal errors Enableable ArrayNodeDefinition is disabled for empty configuration Fixing a bug where the dump() function depended on bundle ordering Add nn (Norwegian Nynorsk) translation files, and improve existing file Problem in phar see mergerequest #25579 [Form] Disallow transform dates beyond the year 9999 Copied NO language files to the new NB locale. [Console] Improve phpdoc on StyleInterface::ask()
nicolas-grekas
added a commit
that referenced
this pull request
Jan 18, 2018
* 3.3: [HttpKernel] DebugHandlersListener should always replace the existing exception handler fix the Composer API being used [Debug] Always decorate existing exception handlers to deal with fatal errors Enableable ArrayNodeDefinition is disabled for empty configuration Fixing a bug where the dump() function depended on bundle ordering [Cache] Fix handling of apcu_fetch() edgy behavior Add nn (Norwegian Nynorsk) translation files, and improve existing file Problem in phar see mergerequest #25579 [Form] Disallow transform dates beyond the year 9999 Copied NO language files to the new NB locale. [Serializer] DateTimeNormalizer handling of null and empty values (returning null or empty instead of new object) [Console] Improve phpdoc on StyleInterface::ask()
nicolas-grekas
added a commit
that referenced
this pull request
Jan 18, 2018
* 3.4: [HttpKernel] DebugHandlersListener should always replace the existing exception handler fix the Composer API being used [Security] Notify that symfony/expression-language is not installed if ExpressionLanguage and ExpressionLanguagePrivider are used [Debug] Always decorate existing exception handlers to deal with fatal errors Enableable ArrayNodeDefinition is disabled for empty configuration Fixing a bug where the dump() function depended on bundle ordering [Cache] Fix handling of apcu_fetch() edgy behavior Add nn (Norwegian Nynorsk) translation files, and improve existing file Problem in phar see mergerequest #25579 [Form] Disallow transform dates beyond the year 9999 Avoid button label translation when it's set to false Copied NO language files to the new NB locale. [Serializer] DateTimeNormalizer handling of null and empty values (returning null or empty instead of new object) Fix options resolver with array allowed types [Console] Improve phpdoc on StyleInterface::ask() [TwigBridge][WIP] Pass the form-check-inline in parent
nicolas-grekas
added a
B536
commit
that referenced
this pull request
Jan 18, 2018
* 4.0: [HttpKernel] DebugHandlersListener should always replace the existing exception handler fix the Composer API being used [Security] Notify that symfony/expression-language is not installed if ExpressionLanguage and ExpressionLanguagePrivider are used [Debug] Always decorate existing exception handlers to deal with fatal errors Enableable ArrayNodeDefinition is disabled for empty configuration Fixing a bug where the dump() function depended on bundle ordering [Cache] Fix handling of apcu_fetch() edgy behavior Add nn (Norwegian Nynorsk) translation files, and improve existing file Problem in phar see mergerequest #25579 [Form] Disallow transform dates beyond the year 9999 Avoid button label translation when it's set to false Copied NO language files to the new NB locale. [Serializer] DateTimeNormalizer handling of null and empty values (returning null or empty instead of new object) Fix options resolver with array allowed types [Console] Improve phpdoc on StyleInterface::ask() [TwigBridge][WIP] Pass the form-check-inline in parent
This was referenced Jan 29, 2018
Merged
Merged
Merged
Merged
Merged
SerhiyMytrovtsiy
added a commit
to SerhiyMytrovtsiy/translation
that referenced
this pull request
Oct 19, 2022
This PR was squashed before being merged into the 2.7 branch (closes #25816). Discussion ---------- Problem in phar see mergerequest #25579 | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> If packed into phar the old version creates path like 'file:///phar%3A/'. see symfony/symfony#25579 Commits ------- 3e0c8ffb43 Problem in phar see mergerequest #25579
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If packed into phar the old version creates path like 'file:///phar%3A/'.