[FrameworkBundle] remove esi/ssi renderers if inactive #25489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Dec 14, 2017
|
Thank you @dmaicher. |
fabpot
added a commit
that referenced
this pull request
Dec 14, 2017
…aicher) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] remove esi/ssi renderers if inactive | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? |no | Tests pass? | yes | Fixed tickets | #25246 | License | MIT | Doc PR | - As found out within #25246 the esi/ssi fragment renderer services were registered for < 3.4 even when the framework config for it was disabled. On 3.4+ this has been fixed already and the service definitions are removed. With this fix the usual exception message appears when `framework.esi` or `framework.ssi` are disabled and using `render_esi(...)` or `render_ssi(...)`: ``` An exception has been thrown during the rendering of a template ("The "esi" renderer does not exist."). ``` **Note: Some people may see this exception when updating to this patch but this just means they are using esi/ssi without enabling it.** Commits ------- e1c3652 [FrameworkBundle] remove esi/ssi renderers if inactive
nicolas-grekas
added a commit
that referenced
this pull request
Dec 15, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] fix merge of 3.3 into 3.4 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - In 3.4+ there were tests for disabled esi/ssi already so now they have been duplicated by merging #25489 up from 2.7 This just cleans up the duplication. Commits ------- 76e16ff [FrameworkBundle] fix merge of 3.3 into 3.4
This was referenced Jan 5, 2018
Merged
Merged
Merged
|
Having an issue with a bundle template that uses render_esi(). It used to just automatically fallback to a normal render() in that instance. Now it fails unless esi is enabled in config.yml. However, I don't want esi enabled for this specific project. Is there a way around this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As found out within #25246 the esi/ssi fragment renderer services were registered for < 3.4 even when the framework config for it was disabled.
On 3.4+ this has been fixed already and the service definitions are removed.
With this fix the usual exception message appears when
framework.esiorframework.ssiare disabled and usingrender_esi(...)orrender_ssi(...):Note: Some people may see this exception when updating to this patch but this just means they are using esi/ssi without enabling it.