8000 [HttpKernel] detect deprecations thrown by container initialization during tests by nicolas-grekas · Pull Request #25413 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] detect deprecations thrown by container initialization during tests #25413

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2017
Merged

[HttpKernel] detect deprecations thrown by container initialization during tests #25413

merged 1 commit into from
Dec 11, 2017

Conversation

nicolas-grekas
Copy link
Member
@nicolas-grekas nicolas-grekas commented Dec 9, 2017 •
edited
Loading
Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #24767
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Dec 9, 2017
@nicolas-grekas nicolas-grekas changed the title [HttpKernel] detect deprecations thrown by container initialization d… [HttpKernel] detect deprecations thrown by container initialization during tests Dec 9, 2017
@nicolas-grekas nicolas-grekas mentioned this pull request Dec 9, 2017
Closed
@chalasr chalasr changed the base branch from master to 3.3 December 10, 2017 00:56
@nicolas-grekas
Copy link
Member Author

Tested, locally, works as expected and fixes the issue.

@fabpot
Copy link
Member
fabpot commented Dec 11, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 81248bc into symfony:3.3 Dec 11, 2017
fabpot added a commit that referenced this pull request Dec 11, 2017
@fabpot
bug #25413 [HttpKernel] detect deprecations thrown by container initi…
d200185 
…alization during tests (nicolas-grekas)

This PR was merged into the 3.3 branch.

Discussion
----------

[HttpKernel] detect deprecations thrown by container initialization during tests

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24767
| License       | MIT
| Doc PR        | -

Commits
-------

81248bc [HttpKernel] detect deprecations thrown by container initialization during tests
@nicolas-grekas nicolas-grekas deleted the kernel-deprec branch December 11, 2017 21:25
This was referenced Dec 15, 2017
Merged
Merged
@fabpot fabpot mentioned this pull request Jan 5, 2018
Merged
@ScullWM ScullWM mentioned this pull request May 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@Simperfit Simperfit Simperfit approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug HttpKernel Status: Reviewed
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @fabpot @Simperfit @chalasr @carsonbot
0