[Translation] modify definitions only if the do exist #25174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Nov 27, 2017
| @@ -81,8 +81,13 @@ public function process(ContainerBuilder $container) | |||
| ; | |||
|
|
|||
| if ($container->hasParameter('twig.default_path')) { | |||
If the `TranslatorPass` is used an application without the Console component, the commands will not be registered. Thus, their service definitions must not be modified.
d753620 to
eab90ef
Compare
nicolas-grekas
approved these changes
Nov 27, 2017
fabpot
approved these changes
Nov 27, 2017
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Nov 27, 2017
…buh) This PR was merged into the 3.4 branch. Discussion ---------- [Translation] modify definitions only if the do exist | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | If the `TranslatorPass` is used an application without the Console component, the commands will not be registered. Thus, their service definitions must not be modified. Commits ------- eab90ef modify definitions only if the do exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
TranslatorPassis used an application without the Consolecomponent, the commands will not be registered. Thus, their service
definitions must not be modified.