[FrameworkBundle] Update translation commands to work with default paths #25065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
commented
Nov 21, 2017
| @@ -78,6 +78,8 @@ | |||
| <argument type="service" id="translator" /> | |||
| <argument type="service" id="translation.reader" /> | |||
| <argument type="service" id="translation.extractor" /> | |||
| <argument>%translator.default_path%</argument> | |||
| <argument on-invalid="null">%twig.default_path%</argument> | |||
There was a problem hiding this comment.
on-invalid="null" strategy over container parameter is not supported or (surely) I'm missing something? Should I do it into FrameworkExtension then?
There was a problem hiding this comment.
yes, it should be done in the DI extension then
3a76018 to
7f292a3
Compare
|
@yceruto do you think you'll be able to have this PR ready before 4.0.0? Would be awesome :) |
|
Sure, today! :) |
060141b to
7661cd6
Compare
7661cd6 to
dc72866
Compare
|
Tests added and all green! Also I've tested this PR in a real project and work like a charm ;) These are all paths where translations and templates are debugged and dumped: Root paths:
Bundle paths:
Ready for reviews! |
nicolas-grekas
approved these changes
Nov 23, 2017
chalasr
approved these changes
Nov 23, 2017
|
|
||
| /** | ||
| * @param TranslatorInterface $translator | ||
| * @param TranslationReaderInterface $reader | ||
| * @param ExtractorInterface $extractor | ||
| * @param string $defaultTransPath | ||
| * @param string $defaultViewsPath |
There was a problem hiding this comment.
I've removed the block as it does not help in any way.
|
|
||
| /** | ||
| * @param TranslationWriterInterface $writer | ||
| * @param TranslationReaderInterface $reader | ||
| * @param ExtractorInterface $extractor | ||
| * @param string $defaultLocale | ||
| * @param string $defaultTransPath | ||
| * @param string $defaultViewsPath |
fabpot
approved these changes
Nov 23, 2017
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Nov 23, 2017
… default paths (yceruto) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Update translation commands to work with default paths | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25062 | License | MIT | Doc PR | symfony/symfony-docs#8634 This should make translation commands (debug & update) work with `translator.default_path` and `twig.default_path` directories (introduced here in 3.4) and their overridden paths if available. Would be great to include also the custom paths mapping by the user, either `translator.paths` as `twig.paths`, but I'm not sure about the right way and probably it should be implemented on another branch. TODO - [x] Add some tests. Commits ------- dc72866 Update translation commands to work with default paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make translation commands (debug & update) work with
translator.default_pathandtwig.default_pathdirectories (introduced here in 3.4) and their overridden paths if available.Would be great to include also the custom paths mapping by the user, either
translator.pathsastwig.paths, but I'm not sure about the right way and probably it should be implemented on another branch.TODO