8000 Replace array|\Traversable by iterable by ro0NL · Pull Request #24969 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Replace array|\Traversable by iterable #24969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2017
Merged

Replace array|\Traversable by iterable #24969

merged 1 commit into from
Nov 18, 2017

Conversation

ro0NL
Copy link
Contributor
@ro0NL ro0NL commented Nov 14, 2017
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

Replace array|\Traversable by iterable, favoring pure API (or less mixed at least :)) and be clear whenever phpdoc is replaced.

https://secure.php.net/manual/en/language.types.iterable.php

@nicolas-grekas
Copy link
Member

is for 2.7

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Nov 15, 2017
@ro0NL
Copy link
Contributor Author
ro0NL commented Nov 15, 2017

Iterable is a pseudo-type introduced in PHP 7.1.

Technically iterable is meaningless in 2.7 (php5.3), but im not sure you're being pragmatic? :)

@nicolas-grekas
Copy link
Member

docblocks have no PHP version constraints

@ro0NL ro0NL changed the base branch from master to 2.0 November 16, 2017 12:38
@ro0NL ro0NL changed the base branch from 2.0 to 2.7 November 16, 2017 12:38
@ro0NL
Copy link
Contributor Author
ro0NL commented Nov 16, 2017

Done. Symfony\Component\Cache\Traits\AbstractTrait::doFetch left for 3.3

@fabpot
Copy link
Member
fabpot commented Nov 18, 2017

Thank you @ro0NL.

@fabpot fabpot merged commit 2780889 into symfony:2.7 Nov 18, 2017
fabpot added a commit that referenced this pull request Nov 18, 2017
This PR was merged into the 2.7 branch.

Discussion
----------

Replace array|\Traversable by iterable

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

Replace `array|\Traversable` by `iterable`, favoring pure API (or less mixed at least :)) and be clear whenever phpdoc is replaced.

https://secure.php.net/manual/en/language.types.iterable.php

Commits
-------

2780889 Replace array|\Traversable by iterable
@ro0NL ro0NL deleted the iterable branch November 18, 2017 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0