-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
update the pull request template #24869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Q | A |
---|---|
Branch? | 2.7 |
Bug fix? | no |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | |
License | MIT |
Doc PR |
Thanks @xabbuh. |
This PR was merged into the 2.7 branch. Discussion ---------- update the pull request template | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- a64f7c1 update the pull request template
@@ -1,6 +1,6 @@ | |||
| Q | A | |||
| ------------- | --- | |||
| Branch? | 3.4 or master / 2.7, 2.8 or 3.3 <!-- see comment below --> | |||
| Branch? | master / 2.7, 2.8, 3.3, or 3.4 <!-- see comment below --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is going to need another change in 3 weeks to add 4.0, better wait?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
race condition :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking the same, but n 8000 ow that the PR is done...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good to have merged it now. Another in 4 weeks, no big deal :)