10000 update the pull request template by xabbuh · Pull Request #24869 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

update the pull request template #24869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2017
Merged

update the pull request template #24869

merged 1 commit into from
Nov 8, 2017

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Nov 8, 2017
Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 2.7 milestone Nov 8, 2017
@chalasr
Copy link
Member
chalasr commented Nov 8, 2017

Thanks @xabbuh.

@chalasr chalasr merged commit a64f7c1 into symfony:2.7 Nov 8, 2017
chalasr added a commit that referenced this pull request Nov 8, 2017
This PR was merged into the 2.7 branch.

Discussion
----------

update the pull request template

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

a64f7c1 update the pull request template
@@ -1,6 +1,6 @@
| Q | A
| ------------- | ---
| Branch? | 3.4 or master / 2.7, 2.8 or 3.3 <!-- see comment below -->
| Branch? | master / 2.7, 2.8, 3.3, or 3.4 <!-- see comment below -->
Copy link
Member
@nicolas-grekas nicolas-grekas Nov 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is going to need another change in 3 weeks to add 4.0, better wait?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

race condition :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking the same, but n 8000 ow that the PR is done...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to have merged it now. Another in 4 weeks, no big deal :)

@xabbuh xabbuh deleted the pr-template branch November 8, 2017 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0