update the pull request template #24869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
fabpot
approved these changes
Nov 8, 2017
Simperfit
approved these changes
Nov 8, 2017
|
Thanks @xabbuh. |
chalasr
added a commit
that referenced
this pull request
Nov 8, 2017
This PR was merged into the 2.7 branch. Discussion ---------- update the pull request template | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- a64f7c1 update the pull request template
| @@ -1,6 +1,6 @@ | |||
| | Q | A | |||
| | ------------- | --- | |||
| | Branch? | 3.4 or master / 2.7, 2.8 or 3.3 <!-- see comment below --> | |||
| | Branch? | master / 2.7, 2.8, 3.3, or 3.4 <!-- see comment below --> | |||
There was a problem hiding this comment.
this is going to need another change in 3 weeks to add 4.0, better wait?
There was a problem hiding this comment.
I was thinking the same, but now that the PR is done...
There was a problem hiding this comment.
I think it's good to have merged it now. Another in 4 weeks, no big deal :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.