[FrameworkBundle][Config] fix: do not add resource checkers for no-debug #24824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Nov 5, 2017
ogizanagi
approved these changes
Nov 5, 2017
fabpot
approved these changes
Nov 5, 2017
|
Thank you @dmaicher. |
fabpot
added a commit
that referenced
this pull request
Nov 5, 2017
…s for no-debug (dmaicher) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle][Config] fix: do not add resource checkers for no-debug | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24808 | License | MIT | Doc PR | - As mentioned within #24808 replacing the `ConfigCachePass` here 537c496...a442e37#diff-687bdbb38a4dc672ca2a79f23e764892L127 with a tagged iterator argument resulted in resource checkers being added even if debug=false. This resulted in a performance drop as on every request all the checkers have been checked. This restores the previous behavior and does not add any checkers if debug=false. Commits ------- 645f712 [FrameworkBundle][Config] fix: do not add resource checkers for debug=false
|
Great job @dmaicher! |
This was referenced Nov 5, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned within #24808 replacing the
ConfigCachePasshere 537c496...a442e37#diff-687bdbb38a4dc672ca2a79f23e764892L127 with a tagged iterator argument resulted in resource checkers being added even if debug=false.This resulted in a performance drop as on every request all the checkers have been checked.
This restores the previous behavior and does not add any checkers if debug=false.