10000 [Cache] Fix race condition in TagAwareAdapter by nicolas-grekas · Pull Request #24419 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Cache] Fix race condition in TagAwareAdapter #24419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2017
Merged

[Cache] Fix race condition in TagAwareAdapter #24419

merged 1 commit into from
Oct 5, 2017

Conversation

nicolas-grekas
Copy link
Member
@nicolas-grekas nicolas-grekas commented Oct 4, 2017 •
edited
Loading
Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #24240
License MIT
Doc PR -

This code is not needed, and might create a race condition (see linked issue). Let's drop it.
When no tags are set on an item, this stores an empty tags array, instead of deleting the tags array entry at all.

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Oct 4, 2017
@nicolas-grekas nicolas-grekas mentioned this pull request Oct 4, 2017
Closed
@fabpot
Copy link
Member
fabpot commented Oct 5, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit fa24fa8 into symfony:3.3 Oct 5, 2017
fabpot added a commit that referenced this pull request Oct 5, 2017
@fabpot
bug #24419 [Cache] Fix race condition in TagAwareAdapter (nicolas-gre…
fc9acad 
…kas)

This PR was merged into the 3.3 branch.

Discussion
----------

[Cache] Fix race condition in TagAwareAdapter

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24240
| License       | MIT
| Doc PR        | -

This code is not needed, and might create a race condition (see linked issue). Let's drop it.
When no tags are set on an item, this stores an empty tags array, instead of deleting the tags array entry at all.

Commits
-------

fa24fa8 [Cache] Fix race condition in TagAwareAdapter
@nicolas-grekas nicolas-grekas deleted the cache-tag-race branch October 5, 2017 16:37
@fabpot fabpot mentioned this pull request Oct 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simperfit Simperfit Simperfit approved these changes

Assignees
No one assigned
Labels
Bug Cache Status: Reviewed
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @fabpot @Simperfit @carsonbot
0