10000 [Yaml] don't keep internal state between parser runs by xabbuh · Pull Request #22351 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Yaml] don't keep internal state between parser runs #22351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2017
Merged

[Yaml] don't keep internal state between parser runs #22351

merged 1 commit into from
Apr 9, 2017

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Apr 9, 2017
Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh force-pushed the reset-parser-state branch from b2b523e to faf671d Compare April 9, 2017 08:06
@xabbuh xabbuh added this to the 2.7 milestone Apr 9, 2017
@fabpot
Copy link
Member
fabpot commented Apr 9, 2017

Thank you @xabbuh.

@fabpot fabpot merged commit faf671d into symfony:2.7 Apr 9, 2017
fabpot added a commit that referenced this pull request Apr 9, 2017
@fabpot
bug #22351 [Yaml] don't keep internal state between parser runs (xabbuh)
34655e6 
This PR was merged into the 2.7 branch.

Discussion
----------

[Yaml] don't keep internal state between parser runs

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

faf671d don't keep internal state between parser runs
@fabpot
Copy link
Member
fabpot commented Apr 9, 2017

@xabbuh Can I let you merge 2.7 into 2.8/3.2/master?

@xabbuh xabbuh deleted the reset-parser-state branch April 9, 2017 17:55
@xabbuh
Copy link
Member Author
xabbuh commented Apr 10, 2017

@fabpot done

stof
stof reviewed Apr 10, 2017
View reviewed changes
src/Symfony/Component/Yaml/Parser.php
$this->currentLineNb = -1;
$this->currentLine = '';
$value = $this->cleanup($value);
$this->lines = explode("\n", $value);
$this->locallySkippedLineNumbers = array();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should also be reset at the end of the parsing to release memort

@xabbuh xabbuh mentioned this pull request Apr 11, 2017
Merged
fabpot added a commit that referenced this pull request Apr 11, 2017
@fabpot
minor #22367 [Yaml] release memory after parsing (xabbuh)
f478161 
This PR was merged into the 2.7 branch.

Discussion
----------

[Yaml] release memory after parsing

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22351 (comment)
| License       | MIT
| Doc PR        |

Follow up of #22351 to release memory after parsing as suggested by @stof.

Commits
-------

c891413 [Yaml] release memory after parsing
This was referenced May 1, 2017
Merged
Merged
Merged
@ivoba ivoba mentioned this pull request May 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@curry684 curry684 curry684 approved these changes

Assignees
No one assigned
Labels
Bug Status: Needs Review Yaml
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
6 participants
@xabbuh @fabpot @stof @dreamer79 @curry684 @carsonbot
0