8000 [DI] Throw on "configured-keys <> getSubscribedServices()" mismatch by nicolas-grekas · Pull Request #22186 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DI] Throw on "configured-keys <> getSubscribedServices()" mismatch #22186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2017
Merged

[DI] Throw on "configured-keys <> getSubscribedServices()" mismatch #22186

merged 1 commit into from
Mar 29, 2017

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

As reported on Slack, this creates DX issues, and provides no practical benefit. Let's throw instead of logging.

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Mar 27, 2017
@fabpot
Copy link
Member
fabpot commented Mar 29, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 4da8884 into symfony:master Mar 29, 2017
fabpot added a commit that referenced this pull request Mar 29, 2017
@fabpot
minor #22186 [DI] Throw on "configured-keys <> getSubscribedServices(…
329b181 
…)" mismatch (nicolas-grekas)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[DI] Throw on "configured-keys <> getSubscribedServices()" mismatch

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

As reported on Slack, this creates DX issues, and provides no practical benefit. Let's throw instead of logging.

Commits
-------

4da8884 [DI] Throw on "configured-keys <> getSubscribedServices()" mismatch
@nicolas-grekas nicolas-grekas deleted the di-strict branch March 29, 2017 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolas-grekas @fabpot
0