[FrameworkBundle] Fix annotations cache folder path #21552
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Argument 2 sets a cache path since e59f0e0
|
Thank you @akeeman. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 7, 2017
This PR was submitted for the master branch but it was merged into the 3.2 branch instead (closes #21552). Discussion ---------- [FrameworkBundle] Fix annotations cache folder path | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | n/a | Fixed tickets | n/a | License | MIT | Doc PR | n/a The argument at index 2 sets a cache path as it extends the file system adapter by default since e59f0e0, where it did set the version before that. This change now results in annotation cache folders showing up in the project root (because of the overwritten cache root folder). Because cache.annotations has a parent now, this line is not needed anymore and fixes the problem. Commits ------- 8e5cfa7 Fix annotations cache folder path
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument at index 2 sets a cache path as it extends the file system adapter by default since e59f0e0, where it did set the version before that. This change now results in annotation cache folders showing up in the project root (because of the overwritten cache root folder).
Because cache.annotations has a parent now, this line is not needed anymore and fixes the problem.