[FrameworkBundle] Resolve env params in debug:config command #20688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb18a90 to
f3b9610
Compare
f3b9610 to
98dcd51
Compare
|
👍 from my side this fixes the main bug reported in #20684. Status: reviewed |
98dcd51 to
37bbea6
Compare
|
👍 This solution worked for me too. Thanks Nicolas. |
|
👍 |
37bbea6 to
695d100
Compare
|
@nicolas-grekas About #20696, I just checked this out after your last commit and the result is that running It's quite better than the current output but as you can guess I expected to get the actual value of the parameter, which looks not possible actually. Does #20618 helps in that way? Anyway, thank you for this. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 8, 2016
…nd (nicolas-grekas) This PR was merged into the 3.2 branch. Discussion ---------- [FrameworkBundle] Resolve env params in debug:config command | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20696 | License | MIT | Doc PR | - Displays e.g. `url: '%env(DATABASE_URL)%'` instead of `url: env_DATABASE_URL_b188317b1d181eca5f0be35aefdae9c4` when doing `bin/console debug:config doctrine` Commits ------- 695d100 [FrameworkBundle] Resolve env params in debug:config command
Merged
fabpot
added a commit
that referenced
this pull request
Dec 14, 2016
This PR was merged into the 3.2 branch. Discussion ---------- Fix misresolved parameters in debug:config on 3.2 | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a This fixes parameters resolution (classic and env ones) in `debug:config`, again. Merging #20714 broke the fix resolving env parameters made in #20688, and anyway it was mismerged (#20714 was not applied when using the `path` argument, my bad, I should have prevented it). This adds a test which prevents regressions so I hope this is is the last PR on this subject. The buggy output is unfortunately part of the last 3.2 release... It can easily be confirmed by running `debug:config doctrine` on a fresh symfony-demo project Commits ------- c88bc89 Fix misresolved parameters in debug:config on 3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displays e.g.
url: '%env(DATABASE_URL)%'instead of
url: env_DATABASE_URL_b188317b1d181eca5f0be35aefdae9c4when doing
bin/console debug:config doctrine