[WebProfilerBundle] Add system locale+timezone to config panel #20126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Branch? | "master" |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes/no |
| Fixed tickets | comma-separated list of tickets fixed by the PR, if any |
| License | MIT |
| Doc PR | reference to the documentation PR, if any |
|
👍 We need to be very careful to not add too much PHP information here (that's why we have a link to the full PHP config) but these two values seem very important. The only thing I don't like is how the information is displayed. It doesn't look OK to me ... but I don't have an alternative solution right now. I'll try to prepare a proposal. Thanks! |
|
Perhaps, last but not least, consider showing |
|
@javiereguiluz maybe this deserves more.. (separate block/panel?) PHP wise there is the system locale+timezone.. but what about the default app locale, request locale, accepted locales, available locales/ext-intl support. Perhaps these need some form of grouping. Right now all the information would be scattered around panels. Perhaps combine the translation panel with a new intl panel? |
fabpot
added a commit
that referenced
this pull request
Dec 13, 2016
…eguiluz) This PR was squashed before being merged into the 3.3-dev branch (closes #20697). Discussion ---------- Updated the "PHP config" panel in the profiler | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I propose to update this panel taking some of the ideas introduced by @ro0NL in #20126: * Adding more info that helps debugging problems (like 32/64 bits, the locale and the timezone) * Removing anything related to PHP acceleration that is not OPcache or APC ### Before  ### After  Commits ------- 531053b Updated the "PHP config" panel in the profiler
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
…(javiereguiluz) This PR was squashed before being merged into the 3.3-dev branch (closes symfony#20697). Discussion ---------- Updated the "PHP config" panel in the profiler | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I propose to update this panel taking some of the ideas introduced by @ro0NL in symfony#20126: * Adding more info that helps debugging problems (like 32/64 bits, the locale and the timezone) * Removing anything related to PHP acceleration that is not OPcache or APC ### Before  ### After  Commits ------- 531053b Updated the "PHP config" panel in the profiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.