[Form] Add support for DateTimeImmutable #19889
Conversation
| namespace Symfony\Component\Form\Extension\Core\DataTransformer; | ||
|
|
||
| /** | ||
| * @package Symfony\Component\Form\Extension\Core\DataTransformer |
There was a problem hiding this comment.
We don't use @package in symfony core
|
Much better :) |
|
I would like to have an option to use custom DateTime class (extending |
| @@ -108,7 +109,7 @@ public function transform($dateTime) | |||
| * | |||
| * @param array $value Localized date | |||
| * | |||
| * @return \DateTime Normalized date | |||
| * @return \DateTimeInterface Normalized date | |||
There was a problem hiding this comment.
the hint should be explicit here IMO: @return \DateTime|DateTimeImmutable since no other implementation is used.
There was a problem hiding this comment.
I think leaving it as \DateTimeInterface is still semantically correct, and is more concise
|
@gharlan I think this is a topic for another PR. |
4062815 to
8d60d72
Compare
|
@fabpot @webmozart what are the chances of this making it into 3.2 before the end of the development phase? |
|
I'm away for the next few days so I'll work on the docs PR when I return. |
@jameshalsall I hope you returned 😆 |
|
@kaiwa Haha, I completely forgot about this - I'll add it to my TODO list to create the docs PR |
|
This one needs a rebase :) |
|
I would not merge this one as is, in favor of more work to address the last (and most important IMHO) part of the related issue:
|
|
Makes sense. So, I'm closing this one as Symfony 3 does require PHP 5.5+. |
|
I have an idea of what to do for this, but some other issues must be addressed first. |
|
In the mean time, it's really easy to implement a model transformer in user land if needed. |
|
Wish you'd have said that back in September ;) |
This PR is an initial concept for adding support for
\DateTimeImmutablein the Form component.The
DateType,TimeTypeandDateTimeTypenow support a new "input" option called "datetimeimmutable". When this is set the returned values from$form->getData()will be instances of\DateTimeImmutableinstead of\DateTime(which is the case for an "input" value of "datetime" - the default).The existing
DateTimetransformers now take an additional constructor argument indicating whether theDateTimeobject is immutable, affecting the reverse-transformed valueI'm looking for feedback on this approach before I finalise it.