[CS] Respect PSR2 4.2 #19176
Merged
[CS] Respect PSR2 4.2 #19176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm :-0: on this one. |
| public $bar = null; | ||
|
|
||
| public $initialized = false; | ||
|
|
There was a problem hiding this comment.
We don't add blank lines between property declarations
There was a problem hiding this comment.
This LF is "inherited" from the original separator between the property declaration and the next class element. I'll add a test for this behavior.
There was a problem hiding this comment.
|
LGTM, after removing the blank lines also |
| Q | A | ------------- | --- | Branch | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | http://www.php-fig.org/psr/psr-2/#4-2-properties
e8bc2e9 to
d250b1d
Compare
|
I've updated the fixer behavior for line breaks. |
|
I thought this was a CS rule already 😀 (makes sense to me at least), ie i changed it for the workflow component just now #19187 (The blank lines that is) @nicolas-grekas that is part of the rule then too right? |
|
👍 |
|
Thank you @phansys. |
fabpot
added a commit
that referenced
this pull request
Jun 27, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [CS] Respect PSR2 4.2 | Q | A | ------------- | --- | Branch | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | http://www.php-fig.org/psr/psr-2/#4-2-properties I'm writing a [new fixer](PHP-CS-Fixer/PHP-CS-Fixer#1889) (`single_class_element_per_statement`), which intends to avoid multiple class elements in one statement. This PR is a POC about the result of this fixer, so I'd like to know what do you think about, since it will be also added to the `@Symfony` ruleset. Please note that class constants are considered too, but here isn't any offending code about that. Example output: ``` $ ./php-cs-fixer.phar fix . --rules=single_class_element_per_statement -vvv 1) src/Symfony/Component/Console/Tests/Input/InputDefinitionTest.php (single_class_element_per_statement) 2) src/Symfony/Component/DependencyInjection/Tests/ContainerTest.php (single_class_element_per_statement) 3) src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/foo.php (single_class_element_per_statement) 4) src/Symfony/Bridge/ProxyManager/Tests/LazyProxy/Fixtures/includes/foo.php (single_class_element_per_statement) ``` Commits ------- d250b1d [CS] Respect PSR2 4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://www.php-fig.org/psr/psr-2/#4-2-properties
I'm writing a new fixer (
single_class_element_per_statement), which intends to avoid multiple class elements in one statement.This PR is a POC about the result of this fixer, so I'd like to know what do you think about, since it will be also added to the
@Symfonyruleset.Please note that class constants are considered too, but here isn't any offending code about that.
Example output: