Avoid phpunit 5.4 warnings on getMock (2.7+) #19128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this the only class that would need an update? |
|
By the way, according to our new maintenance document we must do this change in the
|
|
@xabbuh I've made a new PR (master) for the other changes as they are only in the master. This is not a major version though, this is a minor (5.1 vs 5.4), thus I think it should be merged upwards as it's a minor change anyway. |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @iltar. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 21, 2016
This PR was merged into the 2.7 branch. Discussion ---------- Avoid phpunit 5.4 warnings on getMock (2.7+) | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19125 | License | MIT | Doc PR | ~ Avoids calling `getMock()` in phpunit 5.4 which will trigger a warning (and thus failing test suite) when used by developers as this TestCase is an extension point. Commits ------- b05014c Avoid phpunit 5.4 warnings on getMock
nicolas-grekas
added a commit
that referenced
this pull request
Jun 21, 2016
This PR was merged into the 3.2-dev branch. Discussion ---------- Avoid phpunit 5.4 warnings on getMock (master) | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19125 | License | MIT | Doc PR | ~ Avoids calling `getMock()` in phpunit 5.4 which will trigger a warning (and thus failing test suite) when used by developers as this TestCase is an extension point. _in the other branches (opposed to #19128), this was not in the `Test` namespace yet but in `Tests`. Therefore I've only added this in the master as changed by @wouterj in e938361._ Commits ------- eb8c27e Avoid phpunit 5.4 warnings on getMock
This was referenced Jun 30, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids calling
getMock()in phpunit 5.4 which will trigger a warning (and thus failing test suite) when used by developers as this TestCase is an extension point.