8000 Fix js comment in profiler by linnaea · Pull Request #18883 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Fix js comment in profiler #18883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2016
Merged

Fix js comment in profiler #18883

merged 1 commit into from
May 26, 2016

Conversation

linnaea
Copy link
Contributor
@linnaea linnaea commented May 26, 2016
Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Single line comment introduced in #18413 causes the toolbar to fail to load with a syntax error.

@javiereguiluz
Copy link
Member

👍

Status: Reviewed

@xabbuh
Copy link
Member
xabbuh commented May 26, 2016

👍

@fabpot
Copy link
Member
fabpot commented May 26, 2016

Thank you @linnaea.

@fabpot fabpot merged commit 91a2f5d into symfony:2.7 May 26, 2016
fabpot added a commit that referenced this pull request May 26, 2016
This PR was merged into the 2.7 branch.

Discussion
----------

Fix js comment in profiler

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Single line comment introduced in #18413 causes the toolbar to fail to load with a syntax error.

Commits
-------

91a2f5d Fix js comment in profiler
@linnaea linnaea deleted the patch-1 branch May 26, 2016 07:57
@fabpot fabpot mentioned this pull request May 26, 2016
This was referenced Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0