[PropertyAccess][DX] Enhance exception that say that some methods are missing if they don't #18732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nykopol Can you please also add a test to prevent future regressions? |
|
@xabbuh I added the test. |
| '"%s" given.', | ||
| $property, | ||
| $reflClass->name, | ||
| implode(' and ', array_map(function($method){ |
There was a problem hiding this comment.
It is offending PSR-2 - 6.Closures.
| @@ -714,6 +714,19 @@ private function getWriteAccessInfo($class, $property, $value) | |||
| // we call the getter and hope the __call do the job | |||
| $access[self::ACCESS_TYPE] = self::ACCESS_TYPE_MAGIC; | |||
| $access[self::ACCESS_NAME] = $setter; | |||
| } elseif (null !== $this->findAdderAndRemover($reflClass, $singulars)) { | |||
|
Thank you @nykopol. |
fabpot
added a commit
that referenced
this pull request
Jun 15, 2016
…methods are missing if they don't (nykopol) This PR was squashed before being merged into the 2.7 branch (closes #18732). Discussion ---------- [PropertyAccess][DX] Enhance exception that say that some methods are missing if they don't | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18694 | License | MIT | Doc PR | When you try do define a manyToMany association but you don't give an array or \Traversable, the raised exception say that some methods are missing while they don't. This PR check if the adder and setter methods exists and if so, give a exception that pointing on the real problem. Commits ------- c46519b [PropertyAccess][DX] Enhance exception that say that some methods are missing if they don't
This was referenced Jun 30, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you try do define a manyToMany association but you don't give an array or \Traversable, the raised exception say that some methods are missing while they don't. This PR check if the adder and setter methods exists and if so, give a exception that pointing on the real problem.