8000 [FrameworkBundle] Fix a typo and add a test to prevent new regressions by GuilhemN · Pull Request #18657 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[FrameworkBundle] Fix a typo and add a test to prevent new regressions< 8000 /bdi> #18657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -998,7 +998,7 @@ private function registerSerializerConfiguration(array $config, ContainerBuilder
$cacheMetadataFactory = new Definition(
CacheClassMetadataFactory::class,
array(
new Reference('serializer.mapping.class_metadata_factory.inner'),
new Reference('serializer.mapping.cache_class_metadata_factory.inner'),
new Reference('cache.pool.serializer'),
)
);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Bundle\FrameworkBundle\Tests\Functional;

/**
* Checks that the container compiles correctly when all the bundle features are enabled.
*/
class ContainerDumpTest extends WebTestCase
{
public function testContainerCompilationInDebug()
{
$client = $this->createClient(array('test_case' => 'ContainerDump', 'root_config' => 'config.yml'));

$this->assertTrue($client->getContainer()->has('serializer'));
}

public function testContainerCompilation()
{
$client = $this->createClient(array('test_case' => 'ContainerDump', 'root_config' => 'config.yml', 'debug' => false));

$this->assertTrue($client->getContainer()->has('serializer'));
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

use Symfony\Bundle\FrameworkBundle\Tests\Functional\Bundle\TestBundle\TestBundle;
use Symfony\Bundle\FrameworkBundle\FrameworkBundle;

return array(
new FrameworkBundle(),
new TestBundle(),
);
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
imports:
- { resource: ../config/default.yml }

framework:
esi: true
ssi: true
fragments: true
profiler: true
router: true
session: true
request: true
templating:
enabled: true
engines: ['php']
assets: true
translator: true
validation: true
serializer: true
property_info: true
csrf_protection: true
form: true
0