[DependencyInjection] anonymous services are always private #18491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| @@ -302,11 +302,7 @@ private function processAnonymousServices(\DOMDocument $xml, $file) | |||
| // give it a unique name | |||
| $id = sprintf('%s_%d', hash('sha256', $file), ++$count); | |||
| $node->setAttribute('id', $id); | |||
|
|
|||
| if ($services = $this->getChildren($node, 'service')) { | |||
There was a problem hiding this comment.
This doesn't seem like it made much sense (was introduced in #10619).
|
Thanks! It's been an hour since I'm trying to understand what's wrong with this :) This change you mention might be useless after 9802a41. |
|
👍 |
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 12, 2016
…e (xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [DependencyInjection] anonymous services are always private | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 0a469a4 anonymous services are always private
This was referenced Apr 29, 2016
Merged
Merged
Merged
|
Reporting a BC break with #18703, although perhaps you could argue that our application had a long-standing bug that was simply revealed. 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.