8000 [PropertyAccess] Fix regression by nicolas-grekas · Pull Request #18449 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PropertyAccess] Fix regression #18449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2016
Merged

[PropertyAccess] Fix regression #18449

merged 1 commit into from
Apr 7, 2016

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 2.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations?
Tests pass? yes
Fixed tickets #18437
License MIT
Doc PR -

All credits go to @MisatoTremor

I don't measure any perf impact.

nicolas-grekas
nicolas-grekas reviewed Apr 5, 2016
View reviewed changes
src/Symfony/Component/PropertyAccess/Tests/Fixtures/TestClass.php

namespace Symfony\Component\PropertyAccess\Tests\Fixtures;

class TestClass
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

borrowed from 2.7

@xabbuh
Copy link
Member
xabbuh commented Apr 6, 2016

👍 LGTM

@stof
Copy link
Member
stof commented Apr 7, 2016

👍

Status: reviewed

@fabpot
Copy link
Member
fabpot commented Apr 7, 2016

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 2b30d48 into symfony:2.3 Apr 7, 2016
fabpot added a commit that referenced this pull request Apr 7, 2016
@fabpot
bug #18449 [PropertyAccess] Fix regression (nicolas-grekas)
416f7d7 
This PR was merged into the 2.3 branch.

Discussion
----------

[PropertyAccess] Fix regression

| Q             | A
| ------------- | ---
| Branch?       | 2.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? |
| Tests pass?   | yes
| Fixed tickets | #18437
| License       | MIT
| Doc PR        | -

All credits go to @MisatoTremor

I don't measure any perf impact.

Commits
-------

2b30d48 [PropertyAccess] Fix regression
@nicolas-grekas nicolas-grekas deleted the fix-prop-access branch April 7, 2016 15:47
This was referenced Apr 29, 2016
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug PropertyAccess Ready Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nicolas-grekas @xabbuh @stof @fabpot @staabm @vsoroka @javiereguiluz @carsonbot
0