[Process] Fixes & testNonBlockingNorClearingIteratorOutput #18419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return WindowsPipes | ||
| */ | ||
| public static function create(Process $process, $input) | ||
| public static function create(Process $process, $input, $haveReadSupport) |
There was a problem hiding this comment.
Should $haveReadSupport be renamed to $hasReadSupport?
There was a problem hiding this comment.
that's the name if the var on the constructor and I don't want to rename it there, thus same name here...
There was a problem hiding this comment.
and "pipes" is plural, so that looks right here
There was a problem hiding this comment.
But we should now remove the $process parameter as it is not needed anymore, right?
There was a problem hiding this comment.
right, fixed by removing the create method, it's not needed at all
b266842 to
7a2a2d0
Compare
7a2a2d0 to
3a109a2
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Apr 4, 2016
…ut (nicolas-grekas) This PR was merged into the 3.1-dev branch. Discussion ---------- [Process] Fixes & testNonBlockingNorClearingIteratorOutput | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17427 | License | MIT | Doc PR | - hasCallback (added on master in #17427) always returns true currently. Commits ------- 3a109a2 [Process] Fixes & testNonBlockingNorClearingIteratorOutput
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasCallback (added on master in #17427) always returns true currently.