8000 [Process] Fix stream_select priority when writing to stdin by nicolas-grekas · Pull Request #18349 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Process] Fix stream_select priority when writing to stdin #18349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2016
Merged

[Process] Fix stream_select priority when writing to stdin #18349

merged 1 commit into from
Mar 30, 2016

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@fabpot
Copy link
Member
fabpot commented Mar 30, 2016

ping @romainneutron
Is it possible to add some tests?

@nicolas-grekas
Copy link
Member Author

@fabpot test case added. It hangs without the patch.

@romainneutron
Copy link
Contributor

👍

@fabpot
Copy link
Member
fabpot commented Mar 30, 2016

Thank you @nicolas-grekas.

@fabpot fabpot merged commit f31e783 into symfony:2.7 Mar 30, 2016
fabpot added a commit that referenced this pull request Mar 30, 2016
@fabpot
bug #18349 [Process] Fix stream_select priority when writing to stdin…
9d7f85e 
… (nicolas-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

[Process] Fix stream_select priority when writing to stdin

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

f31e783 [Process] Fix stream_select priority when writing to stdin
@nicolas-grekas nicolas-grekas deleted the procfix branch April 3, 2016 15:40
This was referenced Apr 29, 2016
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Process Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @fabpot @romainneutron @javiereguiluz @carsonbot
0