8000 [3.0] [Form] fix tests added by #17798 by removing `choices_as_values` by HeahDude · Pull Request #17891 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[3.0] [Form] fix tests added by #17798 by removing choices_as_values #17891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[3.0] [Form] fix tests added by #17798 by removing choices_as_values #17891

wants to merge 3 commits into from

Conversation

HeahDude
Copy link
Contributor
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? not yet
Fixed tickets n/a
License MIT
Doc PR -

This was referenced Feb 22, 2016
Merged
Closed
@HeahDude
Copy link
Contributor Author

Note to the merger :
if I don't rebase on ping just discard two first commits when squashing after merging #17890 in 3.0.

@HeahDude HeahDude changed the title [WIP] [3.0] [Form] fix tests added by #17798 by removing choices_as_values [3.0] [Form] fix tests added by #17798 by removing choices_as_values Feb 27, 2016
fabpot added a commit that referenced this pull request Feb 28, 2016
@fabpot
bug #17798 [2.7] [Form] Fix BC break by allowing 'choice_label' optio…
b630ac7 
…n to be 'false' in ChoiceType (HeahDude)

This PR was merged into the 2.7 branch.

Discussion
----------

[2.7] [Form] Fix BC break by allowing 'choice_label' option to be 'false' in ChoiceType

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17773
| License       | MIT
| Doc PR        | symfony/symfony-docs#6282

- [x] Make tests pass
- [x] Adress a doc PR
- [x] Replace alias by FQCN in tests for 2.8, see #17890
- [x] Remove `choices_as_values` in tests for 3.0, see #17891

Commits
-------

017e1d9 bug #17798 [Form] allow `choice_label` option to be `false`
@fabpot
Copy link
Member
fabpot commented Feb 28, 2016

cherry-picked, thanks.

@fabpot fabpot closed this Feb 28, 2016
@HeahDude HeahDude deleted the fix_tests-17798-3_0 branch March 24, 2016 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HeahDude @fabpot @carsonbot
0