[DependencyInjection] fix dumped YAML snytax #17814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -56,4 +54,9 @@ public function testAddService() | |||
| $this->assertEquals('Unable to dump a service container if a parameter is an object or a resource.', $e->getMessage(), '->dump() throws a RuntimeException if the container to be dumped has reference to objects or resources'); | |||
| } | |||
| } | |||
|
|
|||
| private function assertDumpedYamlEqualsExpectedStructure($yaml, $expected, $message = '') | |||
There was a problem hiding this comment.
I'm not very fond of this method's name. In PHPUnit there is a assertEqualXMLStructure() method, so maybe we could use something like: assertEqualYamlStructure() or assertEqualParsedYaml().
There was a problem hiding this comment.
I like assertEqualYamlStructure(). Changed it everywhere to use this method name.
200ea4f to
30388f1
Compare
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Feb 16, 2016
This PR was merged into the 2.3 branch. Discussion ---------- [DependencyInjection] fix dumped YAML snytax | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | see the failing tests in #17809 Commits ------- 30388f1 [DependencyInjection] fix dumped YAML snytax
This was referenced Feb 16, 2016
xabbuh
added a commit
that referenced
this pull request
Feb 16, 2016
…er feature (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [DependencyInjection] don't rely on deprecated YAML parser feature | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17814 | License | MIT | Doc PR | see [failing tests for the 2.7 branch](https://travis-ci.org/symfony/symfony/jobs/109537695#L2238) Commits ------- c8d387f don't rely on deprecated YAML parser feature
This was referenced Feb 28, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see the failing tests in #17809