Fixed (string) catchable fatal error for PHP Incomplete Class instances #17691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #17586 |
| License | MIT |
| Doc PR | - |
|
AppVeyor build failed (not related) |
|
👍 Status: reviewed |
| { | ||
| $array = new \ArrayObject($value); | ||
|
|
||
| return $array['__PHP_Incomplete_Class_Name']; |
There was a problem hiding this comment.
cant u just access this as a property without arrayobject?
There was a problem hiding this comment.
$foo = new \__PHP_Incomplete_Class();
echo $foo->__PHP_Incomplete_Class_Name;results in:
The script tried to execute a method or access a property of an incomplete object.
Please ensure that the class definition "unknown" of the object you are trying to
operate on was loaded _before_ unserialize() gets called or provide a __autoload()
function to load the class definition.
There was a problem hiding this comment.
yeah, __PHP_Incomplete_Class is really weird (the fact that is_object returns false for it is a first WTF, but not the only one)
|
👍 |
|
This one should be merged in 2.7, but first, we need a PR on 2.3 as the bug probably exists there as well. |
|
|
|
@yceruto but the bug also exists in 2.3. It is just not extracted to a separate class |
|
@stof right, I'll create a PR to 2.3 |
|
I've opened a PR for 2.3 branch (#17766) |
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Feb 12, 2016
…ass instances (yceruto) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #17691). Discussion ---------- Fixed (string) catchable fatal error for PHP Incomplete Class instances | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17586 | License | MIT | Doc PR | - Commits ------- 4b7ed98 avoid (string) catchable fatal error for instances of __PHP_Incomplete_Class
This was referenced Feb 28, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.