8000 [Serializer] Unset object_to_populate after using it by dunglas · Pull Request #17281 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] Unset object_to_populate after using it #17281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Serializer] Unset object_to_populate after using it #17281

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
729b20f
[Serializer] Unset object_to_populate after using it
dunglas Jan 6, 2016
b59c115
Update PHPDoc
dunglas Jan 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,9 @@ protected function prepareForDenormalization($data)
* Instantiates an object using constructor parameters when needed.
*
* This method also allows to denormalize data into an existing object if
* it is present in the context with the object_to_populate key.
* it is present in the context with the object_to_populate. This object
* is removed from the context before being returned to avoid side effects
* when recursively normalizing an object graph.
*
* @param array $data
* @param string $class
Expand All @@ -298,7 +300,10 @@ protected function instantiateObject(array &$data, $class, array &$context, \Ref
is_object($context['object_to_populate']) &&
$class === get_class($context['object_to_populate'])
) {
return $context['object_to_populate'];
$object = $context['object_to_populate'];
unset($context['object_to_populate']);

return $object;
}

$constructor = $reflectionClass->getConstructor();
Expand Down
0