CS: use nowdoc instead of heredoc #17086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| This template is used for translation message extraction tests< 8000 /span> | |||
| <?php echo $view['translator']->trans('single-quoted key') ?> | |||
| <?php echo $view['translator']->trans('double-quoted key') ?> | |||
| <?php echo $view['translator']->trans(<<<EOF | |||
| <?php echo $view['translator']->trans(<<<'EOF' | |||
There was a problem hiding this comment.
this must be reverted. It is precisely testing the extraction from heredoc (extracting from nowdoc is tested 3 lines later)
f5f8fa0 to
7ce6b7d
Compare
|
Personally, I'm |
|
We already force single quotes instead of double quotes (when possible). So in my opinion it would be consistent to do it the same way with nowdoc vs. heredoc. |
|
|
||
| return \$this->doGenerate(\$variables, \$defaults, \$requirements, \$tokens, \$parameters, \$name, \$referenceType, \$hostTokens); | ||
| return $this->doGenerate($variables, $defaults, $requirements, $tokens, $parameters, $name, $referenceType, $hostTokens); |
|
👍 (not a big one but still :) ) |
|
👍 |
|
Thank you @gharlan. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 28, 2015
This PR was merged into the 2.3 branch. Discussion ---------- CS: use nowdoc instead of heredoc | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | — | License | MIT | Doc PR | — if this is accepted, we could add the fixer to symfony level of php-cs-fixer: PHP-CS-Fixer/PHP-CS-Fixer#1580 Commits ------- 3dca549 use nowdoc instead of heredoc
|
I merged 2.3 up to master without looking for more heredoc to change, which means they may be more in 2.7 and up. |
|
Great to hear @nicolas-grekas |
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
This PR was merged into the 2.3 branch. Discussion ---------- CS: use nowdoc instead of heredoc | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | — | License | MIT | Doc PR | — if this is accepted, we could add the fixer to symfony level of php-cs-fixer: PHP-CS-Fixer/PHP-CS-Fixer#1580 Commits ------- 3dca549 use nowdoc instead of heredoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if this is accepted, we could add the fixer to symfony level of php-cs-fixer: PHP-CS-Fixer/PHP-CS-Fixer#1580