[FrameworkBundle][Validator] Fix apc cache service & config #16794
Conversation
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #16793 |
| License | MIT |
| Doc PR | - |
|
Beware, the new service does not implements the same interface. |
| ->scalarNode('cache') | ||
| ->beforeNormalization() | ||
| // Can be removed in 3.0, once ApcCache support is dropped | ||
| ->ifString()->then(function ($v) { return 'apc' === $v ? 'validator.mapping.cache.apc' : $v; }) |
There was a problem hiding this comment.
This BC break should trigger a deprecation in previous versions right?
There was a problem hiding this comment.
The deprecation seems to have been triggered through the new validator.mapping.cache.doctrine.apc service in previous versions...
And this service has been removed in 3.0.
I'm getting lost in the operation.
I think something went wrong during a merge or this wasn't expected to be as it is right now:
validator.mapping.cache.doctrine.apc wasn't supposed to be marked as deprecated nor removed IMO.
validator.mapping.cache.apc was.
I'm going to make validator.mapping.cache.apc an alias of the new validator.mapping.cache.doctrine.apc service, but it should probably have been removed instead.
|
Hmm, you're right. It should be based on |
|
This PR has been submitted by mistake on |
…g (ogizanagi) This PR was merged into the 3.0 branch. Discussion ---------- [FrameworkBundle][Validator] Fix apc cache service & config | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16793 | License | MIT | Doc PR | - _Keep track of #16794 (comment) _NOTE_: This PR is on standby. If #16822 is merged, this one might probably be closed, as everything will be done during the 62D2 merge. Commits ------- 94a1728 [FrameworkBundle][Validator] Fix apc cache service & config