JsonResponse fix #16689
Closed
JsonResponse fix #16689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed $this->data to an container for setting or adding scalar content to ResponseObject. $this->content is a string representation of $this->data. $this->update() is an private function to sync $this->data and $this->content. When modifying either $data or $content or by setting encoding options, the two are synced.
Changed $this->update() to sync this->data and $this->content
Updated JsonResponse after feedback
| */ | ||
| public function setData($data = array()) | ||
| { | ||
| $this->data = $data; |
There was a problem hiding this comment.
you are still breaking BC by storing the array/object/scalar instead of storing the JSON string.
And it might even break things in case your data is a mutable object, as your data could be mutated before you trigger another update
|
Closing as this breaks BC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please also consider closed PR discussions:
#16551
#16563