[Form] Allow choices with duplicated content #16436
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no, but not sure |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #15606 |
| License | MIT |
| Doc PR |
|
Test fail reason not related to this PR. Please review. |
|
@ewgRa is there any reason you do the PR against 2.8 ? IMO this should be done against 2.7 which is impacted by the bug and is the LTS version. |
Kind of my fault, I check outdated 2.7 before start working on it. Also I'm not sure that this is not a broken BC. I recreate PR with 2.7: #16582 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.