8000 added logging of unused tags by fabpot · Pull Request #15963 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

added logging of unused tags #15963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2015
Merged

added logging of unused tags #15963

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f51fe4a
[FrameworkBundle] [DependencyInjection] added logging of unused tags …
Oct 29, 2014
d3271e1
missing tags in whitelist
fabpot Sep 28, 2015
95c9f50
added some tests
fabpot Sep 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
missing tags in whitelist
  • Loading branch information
@fabpot
fabpot committed Sep 28, 2015
commit d3271e1fae8614d240578d0e3a723a280c790298
4 changes: 4 additions & 0 deletions src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/UnusedTagsPass.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ class UnusedTagsPass implements CompilerPassInterface
*/
protected $whitelist = array(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't make it protected by default. If we want to offer an extension point, I'd recommend a separate method to add a tag to the whitelist.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to private. I've just added some tests to an existing PR, but that should have been private from the get go.

"console.command",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use single quotes please

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed

"config_cache.resource_checker",
"data_collector",
"form.type",
"form.type_extension",
Expand All @@ -38,10 +39,13 @@ class UnusedTagsPass implements CompilerPassInterface
"kernel.event_subscriber",
"kernel.fragment_renderer",
"monolog.logger",
"routing.expression_language_provider",
"routing.loader",
"security.expression_language_provider",
"security.remember_me_aware",
"security.voter",
"serializer.encoder",
"serializer.normalizer",
"templating.helper",
"translation.dumper",
"translation.extractor",
Expand Down
0