8000 [2.8] Deprecate IntrospectableContainerInterface by nicolas-grekas · Pull Request #15694 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[2.8] Deprecate IntrospectableContainerInterface #15694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2015
Merged

[2.8] Deprecate IntrospectableContainerInterface #15694

merged 1 commit into from
Sep 6, 2015

Conversation

nicolas-grekas
Copy link
Member
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Patch on Security is required for tests compat with 3.0, see #15684
IntrospectableContainerInterface is already deprecated in master.

@nicolas-grekas nicolas-grekas changed the title [2.8] Cleanup [2.8] Deprecate IntrospectableContainerInterface Sep 4, 2015
@Tobion
Copy link
Contributor
Tobion commented Sep 4, 2015

ref #15346 (comment)

@nicolas-grekas
Copy link
Member Author

Thanks for the link.
Code wanting to be both 3.0 and 2.x compatible could rely on ContainerInterface + method_exists
Can we consider this?

@Tobion
Copy link
Contributor
Tobion commented Sep 4, 2015

I agree

@nicolas-grekas nicolas-grekas mentioned this pull request Sep 5, 2015
Merged
@nicolas-grekas
Copy link
Member Author

I added 3.0 compat in Symfony\Bridge\ProxyManager\LazyProxy\PhpDumper\ProxyDumper

@nicolas-grekas nicolas-grekas mentioned this pull request Sep 5, 2015
Merged
@Tobion
Copy link
Contributor
Tobion commented Sep 5, 2015

👍

@Tobion
Copy link
Contributor
Tobion commented Sep 5, 2015

Status: Reviewed

nicolas-grekas
nicolas-grekas reviewed Sep 6, 2015
View reviewed changes
src/Symfony/Bundle/SecurityBundle/composer.json
"symfony/dom-crawler": "~2.0,>=2.0.5|~3.0.0",
"symfony/form": "~2.8",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two constraints are duplicates of similar ones in framework-bundle, and for some reason (a bug in composer?) they can create dependency resolving failure. Removing them fixes the issue without changing anything to the resolved set.

@nicolas-grekas nicolas-grekas mentioned this pull request Sep 6, 2015
Merged
@fabpot
Copy link
Member
fabpot commented Sep 6, 2015

Thank you @nicolas-grekas.

@fabpot fabpot merged commit c2b94a1 into symfony:2.8 Sep 6, 2015
fabpot added a commit that referenced this pull request Sep 6, 2015
@fabpot
minor #15694 [2.8] Deprecate IntrospectableContainerInterface (nicola…
d5c046d 
…s-grekas)

This PR was merged into the 2.8 branch.

Discussion
----------

[2.8] Deprecate IntrospectableContainerInterface

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Patch on Security is required for tests compat with 3.0, see #15684
IntrospectableContainerInterface is already deprecated in master.

Commits
-------

c2b94a1 [2.8] Cleanup
@nicolas-grekas nicolas-grekas deleted the clean28 branch September 6, 2015 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Ready Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @Tobion @fabpot @carsonbot
0