8000 [Intl] fix IntlDataFormatter default pattern by ewgRa · Pull Request #15045 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Intl] fix IntlDataFormatter default pattern #15045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Intl] fix IntlDataFormatter default pattern #15045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/Intl/DateFormatter/IntlDateFormatter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@ protected function getDefaultPattern()
if (self::NONE !== $this->timetype) {
$patternParts[] = $this->defaultTimeFormats[$this->timetype];
}
$pattern = implode(' ', $patternParts);
$pattern = implode(', ', $patternParts);

return $pattern;
}
Expand Down
15 changes: 15 additions & 0 deletions src/Symfony/Component/Intl/Tests/DateFormatter/IntlDateFormatterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,21 @@ public function testConstructorWithUnsupportedLocale()
new IntlDateFormatter('pt_BR', IntlDateFormatter::MEDIUM, IntlDateFormatter::SHORT);
}

public function testEqualWithNative()
{
$native = \IntlDateFormatter::create('en', \IntlDateFormatter::MEDIUM, \IntlDateFormatter::SHORT);

if ($native instanceof IntlDateFormatter) {
$this->markTestSkipped('No intl extension installed');
}

$replacement = IntlDateFormatter::create('en', IntlDateFormatter::MEDIUM, IntlDateFormatter::SHORT);

$time = time();

$this->assertSame($native->format($time), $replacement->format($time));
}

public function testStaticCreate()
{
$formatter = IntlDateFormatter::create('en', IntlDateFormatter::MEDIUM, IntlDateFormatter::SHORT);
Expand Down
0