10000 [3.0] [FrameworkBundle] Drop backward compatibility for debug commands by matthieuauger · Pull Request #14091 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[3.0] [FrameworkBundle] Drop backward compatibility for debug commands #14091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2015

Conversation

matthieuauger
Copy link
Contributor
Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
License MIT

Remove the aliases set for backward compatibility. Currently theses commands are displayed twice in the bin/console list output (command:debug and debug:command)

@matthieuauger matthieuauger force-pushed the drop-bc-debug-commands branch from 158f4fe to 14bbd28 Compare March 27, 2015 23:38
@fabpot
Copy link
Member
fabpot commented Mar 30, 2015

Thank you @matthieuauger.

@fabpot fabpot merged commit 14bbd28 into symfony:master Mar 30, 2015
fabpot added a commit that referenced this pull request Mar 30, 2015
…r debug commands (matthieuauger)

This PR was merged into the 3.0-dev branch.

Discussion
----------

[3.0] [FrameworkBundle] Drop backward compatibility for debug commands

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Remove the aliases set for backward compatibility. Currently theses commands are displayed twice in the bin/console list output (command:debug and debug:command)

Commits
-------

14bbd28 Drop backward compatibility for debug commands
@stof
Copy link
Member
stof commented Apr 2, 2015

This needs to be done in other bundles too, not only in FrameworkBundle

@matthieuauger
Copy link
Contributor Author

@fabpot already did it in TwigBundle symfony/twig-bundle@6e95055

The last one should be SwiftMailer, I'll make the PR

@dupuchba
Copy link
Contributor
dupuchba commented Apr 2, 2015

👍

@fabpot fabpot mentioned this pull request Nov 16, 2015
fabpot added a commit to symfony/swiftmailer-bundle that referenced this pull request May 20, 2017
…d (matthieuauger)

This PR was merged into the 2.6-dev branch.

Discussion
----------

[Symfony 3.0] Drop backward compatibility for debug command

| Q | A |
| --- | --- |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| License | MIT |

Related to symfony/symfony#14091
Should we merge it in master create a branch for 3.0 features/bc breaks ?

Commits
-------

f876831 Drop backward compatibility for debug command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0