8000 [DependencyInjection] don't try to declare fixture class twice by xabbuh · Pull Request #13947 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DependencyInjection] don't try to declare fixture class twice #13947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[DependencyInjection] don't try to declare fixture class twice #13947

wants to merge 1 commit into from

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Mar 17, 2015
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

In #13914, I missed the fact that one of the fixture files declares a class. Thus leading to aborted tests when the file is loaded for the second time (PHP Fatal error: Cannot redeclare class Container14\ProjectServiceContainer).

@xabbuh xabbuh mentioned this pull request Mar 17, 2015
Merged
@xabbuh
Copy link
Member Author
xabbuh commented Mar 17, 2015

Closing in favor of #13941.

@xabbuh xabbuh closed this Mar 17, 2015
@xabbuh xabbuh deleted the fix-tests branch March 17, 2015 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xabbuh
0