[2.7] [FrameworkBundle] bugfix in configuration for assets #13701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was also fixed as part of #13672. |
|
I'll remove it from #13672, as this PR also fixes the message. |
| @@ -86,6 +86,24 @@ public function testInvalidValueTrustedProxies() | |||
| )); | |||
| } | |||
|
|
|||
| /** | |||
| * @expectedException \Symfony\Component\Config\Definition\Exception\InvalidConfigurationException | |||
There was a problem hiding this comment.
Could you also add @expectedExceptionMessage?
| Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a If both of configurations are defined, the exception is break because it isn't defined properly (missing backslash in FQCN for ```\LogicException```). Also, the message was wrong (it's referred to "templating.templating" instead of "framework.templating").
5e40de9 to
3b4c23f
Compare
|
Thank you @phansys. |
fabpot
added a commit
that referenced
this pull request
Feb 16, 2015
…ts (phansys) This PR was merged into the 2.7 branch. Discussion ---------- [2.7] [FrameworkBundle] bugfix in configuration for assets | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a If both of configurations are defined, the exception breaks because it isn't defined properly (missing backslash in FQCN for ```\LogicException```). Also, the message was wrong (it's referred to "templating.templating" instead of "framework.templating"). Commits ------- 3b4c23f [2.7] [FrameworkBundle] bugfix in configuration for assets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If both of configurations are defined, the exception breaks because it isn't
defined properly (missing backslash in FQCN for
\LogicException).Also, the message was wrong (it's referred to "templating.templating" instead of
"framework.templating").