8000 removed deprecated asset feature by fabpot · Pull Request #13666 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

removed deprecated asset feature #13666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 12, 2015
Merged

removed deprecated asset feature #13666

merged 2 commits into from
Feb 12, 2015

Conversation

fabpot
Copy link
Member
@fabpot fabpot commented Feb 12, 2015
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@fabpot fabpot force-pushed the assets-deprecated-removal branch 2 times, most recently from a8648fc to fefa830 Compare February 12, 2015 09:47
@fabpot fabpot force-pushed the assets-deprecated-removal branch from fefa830 to 52badd0 Compare February 12, 2015 11:56
@fabpot
Copy link
Member Author
fabpot commented Feb 12, 2015

Thank you @fabpot.

@fabpot fabpot merged commit 52badd0 into symfony:master Feb 12, 2015
fabpot added a commit that referenced this pull request Feb 12, 2015
@fabpot
feature #13666 removed deprecated asset feature (fabpot)
d948837 
This PR was merged into the 3.0-dev branch.

Discussion
----------

removed deprecated asset feature

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

52badd0 removed deprecated Twig features
8018d4b removed deprecated asset feature
@jeremyFreeAgent
Copy link
Contributor

Thank you @fabpot.

;)

@jakzal jakzal mentioned this pull request Feb 26, 2015
Merged
fabpot added a commit that referenced this pull request Feb 26, 2015
@fabpot
minor #13800 [FrameworkBundle] Update assets configuration tests (jak…
5a60ba4 
…zal)

This PR was merged into the 3.0-dev branch.

Discussion
----------

[FrameworkBundle] Update assets configuration tests

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Previously, assets where enabled if `templating` didn't contain asset configuration. This has been removed in #13666.

Instead of enabling it back I propose to keep it disabled and update the tests instead, since we already discussed disabling all FrameworkBundle features by default for 3.0 (#13703).

Commits
-------

5007b41 [Form] Replace use of bind() with submit() in a test.
494e300 [SecurityBundle] Enable assets in functional tests.
4c26875 [FrameworkBundle] Fix a default config test case and add a new one for enabling assets.
b0f6a19 [FrameworkBundle] Remove a legacy test.
This was referenced Jun 12, 2015
Closed
Closed
@TomasVotruba
Copy link
Contributor

What to use instead of asset in templates?

@fabpot fabpot mentioned this pull request Nov 16, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabpot @jeremyFreeAgent @TomasVotruba
0