8000 Update ExceptionController.php by nahpeps · Pull Request #13169 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Update ExceptionController.php #13169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update ExceptionController.php #13169

wants to merge 1 commit into from

Conversation

nahpeps
Copy link
@nahpeps nahpeps commented Dec 30, 2014

Changed namespace of used FlattenException from HttpKernel to Debug, because SF 2.6 call the showAction with a Symfony\Component\Debug\Exception\FlattenException

The Problem can be reproduced when you use the /app_dev.php/_error/500 example taken from
http://symfony.com/doc/current/cookbook/controller/error_pages.html

@nahpeps
Update ExceptionController.php
8ca1f2a 
Changed namespace of used FlattenException from HttpKernel to Debug, because SF 2.6 call the showAction with a Symfony\Component\Debug\Exception\FlattenException
@xabbuh
Copy link
Member
xabbuh commented Dec 30, 2014

This is not backward compatible and will lead to issues if it's done before 3.0 (it was actually done before and lead to issues, see #12844, so it was reverted in 7224bde). It could be merged into the master branch though.

@fabpot
Copy link
Member
fabpot commented Dec 30, 2014

Closing for the reasons explained by @xabbuh

@fabpot fabpot closed this Dec 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nahpeps @xabbuh @fabpot
0