[TwigBridge] Foundation form layout integration #12587
Conversation
|
It's also a matter of maintaining the theme. Any @symfony/deciders willing to maintain it. Personally, I'm 👎 |
|
I'd 👍 as I believe Foundation is a better base for custom apps (more neutral default theme, less override rules needed in the CSS to achieve a custom look) while Bootstrap is better geared at rapid prototyping and I'd argue Symfony is probably still better at building sustainable custom apps than prototypes. |
| {{ date_pattern|replace({ | ||
| '{{ year }}': '<div class="large-4 columns">' ~ form_widget(form.year) ~ '</div>', | ||
| '{{ month }}': '<div class="large-4 columns">' ~ form_widget(form.month) ~ '</div>', | ||
| '{{ day }}': '<div class="large-4 columns">' ~ form_widget(form.day) ~ '</div>', |
|
The whitespace control is missing in this template to remove extra spaces (as done in the default theme) |
|
@totophe Any news on this PR? Are you willing to finish it? |
|
Yes, sorry, I was drawn into our sprints. I'll do that ASAP. |
|
Hi, changes are made. Sorry @stof for the delay. I'll not procrastinate next time. |
|
Would have saved me a some time had this been in the Twig bundle... Thank you! |
| {%- endfor -%} | ||
| {% if form.parent %}</small>{% else %}</div>{% endif %} | ||
| {%- endif %} | ||
| {%- endblock form_errors %} |
|
@totophe could you open a doc PR (see this one for the bootstrap theme: symfony/symfony-docs#4411) |
|
👍 with some comments above |
|
@nicolas-grekas I'll fix that asap (this week) |
|
ping @totophe |
|
Doc PR done: symfony/symfony-docs#5702 :-) |
|
To be consistent with our Bootstrap practice and to be future-proof, we should probably rename the Twig template to |
|
Here you go |
|
I'd 👍 Foundation make developement easier. |
|
ping @symfony/deciders |
|
Foundation is interesting and it looks like a good idea to have support for it in Symfony but as I don't often use it and will not help to maintain this theme I prefer abstention. |
|
I am neither pro nor contra. The implementation looks good, but it would be good to have someone being able to maintain the theme. On the other hand, a form theme is not a real big deal and could probably live in the core nonetheless. |
|
ok, let's merge it in 2.8. If we have too many bug reports and noone fixing them, we will still be able to deprecate it and remove it later on. |
|
Thank you @totophe. |
|
As I've proposed this feature, I'm willing to maintain it if any issue would occur. |
This PR was squashed before being merged into the 2.8 branch (closes #5702). Discussion ---------- Added a reference to the Foundation form theme | Q | A | |---|---| | Doc fix? | no | | New docs? | yes | | Applies to | N/A | See pull request: symfony/symfony#12587 Commits ------- 23c7798 Added a reference to the Foundation form theme
As symfony integrate in its roots Bootstrap layout, why not also include Foundation layout? I think it's not a matters of including all the css frameworks in symfony but at least having two instead of one would be interesting to have a basic choice.
@hhamon told me I should create this PR :-D :-p ;-)