10000 [FrameworkBundle] register `TranslatorListener` service by xabbuh · Pull Request #12182 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[FrameworkBundle] register TranslatorListener service #12182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2014

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Oct 8, 2014
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #12167
License MIT
Doc PR

Since the TranslatorListener was not registered as a service, the
proper locale would never have been passed from the current request
to the translator.

Since the `TranslatorListener` was not registered as a service, the
proper locale would never have been passed from the current request
to the translator.
@Tobion
Copy link
Contributor
Tobion commented Oct 8, 2014

👍

1 similar comment
@jakzal
Copy link
Contributor
jakzal commented Oct 8, 2014

👍

@fabpot
Copy link
Member
fabpot commented Oct 8, 2014

Thank you @xabbuh.

@fabpot fabpot 9AFA merged commit 3b578a6 into symfony:master Oct 8, 2014
fabpot added a commit that referenced this pull request Oct 8, 2014
…abbuh)

This PR was merged into the 2.6-dev branch.

Discussion
----------

[FrameworkBundle] register `TranslatorListener` service

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12167
| License       | MIT
| Doc PR        |

Since the `TranslatorListener` was not registered as a service, the
proper locale would never have been passed from the current request
to the translator.

Commits
-------

3b578a6 register `TranslatorListener` service
@xabbuh xabbuh deleted the issue-12167 branch October 9, 2014 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0